[Fix] Custom automation tasks change models when another user targets them - #2443
Open
roomote-roomote[bot] wants to merge 2 commits into
Open
[Fix] Custom automation tasks change models when another user targets them#2443roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 10, 2026 05:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
A user token could previously target a known custom-automation task ID owned by another member and change its persisted model settings, potentially restarting its live harness. The web mutation already enforced the restrictive task-access path, but the agent-facing API only checked that some user context existed.
Impact
Unauthorized members now receive a not-found response before any run lookup, model-setting persistence, or sandbox RPC. Focused real-database coverage, the full API suite, repository type checks and lint, and the pre-push checks pass; browser proof is not applicable to this server-side authorization invariant.