[Fix] Webhook deliveries remain unfinalized after audit write failures - #2445
Merged
roomote-roomote[bot] merged 1 commit intoSep 10, 2026
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 10, 2026 06:08
daniel-lxs
approved these changes
Sep 10, 2026
roomote-roomote
Bot
deleted the
fix/webhook-terminal-status-recovery
branch
September 10, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The recorders inserted a durable placeholder before invoking the handler, but only logged a failed terminal audit update. A later provider redelivery then conflicted with the placeholder and returned, leaving the row permanently nonterminal. Replaying the handler would risk duplicating non-idempotent side effects, so recovery finalizes only the audit state.
This remains independent from #2381 and #1949: those PRs use adjacent durable webhook concepts but do not own or modify these recorder paths.
Impact
After redelivery, affected audit rows now have
failed_atand a self-describing unknown-outcome error instead of remaining unclassified; handler invocation count remains one. If redelivery races a still-running original handler, the provisional unknown result is atomically replaced by that handler's eventual success or failure.The full API suite passed 2,602 tests, focused recorder coverage passed 18 tests, and repository lint, typechecks, knip, commit hooks, and pre-push checks passed. Browser proof is not applicable because this is database transaction and deduplication behavior with no rendered surface. A row can still remain nonterminal if no provider redelivery occurs, and a repeated database failure can defer recovery to another redelivery.