[Fix] Custom automation results stay stale when user runs them now - #2446
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Custom automation results stay stale when user runs them now#2446roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The Run now action only showed a toast, unlike adjacent custom-automation mutations that refresh the list. Immediate outcomes therefore stayed stale until reload, and queued Fast runs needed bounded follow-up because their durable result is recorded asynchronously after the mutation returns.
Impact
Custom automation cards now show persisted run metadata without requiring a reload. The change does not add indefinite polling, clears pending refresh timers when the button unmounts, and avoids creating new timers if the mutation resolves after navigation.
PR #2444 changes cadence rendering in the same component and later cadence-specific tests. This PR does not modify
cadenceLabelor its call site; a synthetic merge-tree check against #2444 completed without conflicts after the lifecycle fix. Focused and full client coverage, web static checks, knip, and pre-push checks passed. The lifecycle fix has no visible mounted UI state to capture, so browser proof is not applicable to the updated head.