Skip to content

[Improve] Unify built-in and custom automations - #2451

Merged
brunobergher merged 11 commits into
developfrom
feature/unified-automations-list-0pfjzocqemkvn
Sep 10, 2026
Merged

[Improve] Unify built-in and custom automations#2451
brunobergher merged 11 commits into
developfrom
feature/unified-automations-list-0pfjzocqemkvn

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Present accessible custom and built-in automations in one responsive list instead of separate Custom, Enabled, and Available sections.
  • Add All, Custom, and Built-in radio filters plus search across names, descriptions, schedules or event triggers, and destination summaries.
  • Show accurate trigger and destination context for built-ins, including webhook-driven automations that use a stored schedule value only as an enablement sentinel.
  • Use visible left-side switches for every row, retain applicable Run now and Configure actions, and keep Delete custom-only.
  • Align bare icons with both name lines, clamp custom prompts to two lines, use bounded desktop columns, and stack mobile content under the title text.
  • Move scheduling timezone into the desktop toolbar while retaining its mobile placement, and hide unavailable built-in filtering for members.
  • Stabilize deployment-wide automation settings tests and make telemetry-transition fixtures explicit against the seeded manager-stats default.

Why this change was made

The Automations page split related configuration across different layouts and gave built-ins less at-a-glance context than custom automations. A single searchable list makes the full accessible catalog easier to scan without changing who can see or manage each record.

Impact

Admins see built-in and custom automations together, while members continue to see only the custom automations they own and no unavailable Built-in filter. Existing authorization, destination resolution, configuration dialogs, and mutation permissions are unchanged.

The branch now includes current develop; the previously failing Test job passes on the resulting merge head. Browser proof was not rerun for the test-only CI stabilization change.

@roomote-community

roomote-community Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • Members can no longer select the Built-in filter when their page renders no built-in rows.
  • Built-in Run now controls are passed to AutomationCard and rendered.
  • Custom automation task-history links were removed with no replacement. — dismissed: Bruno clarified the right-side action set as Run now, Configure, and custom-only Delete.
  • Members without custom automations see the appropriate empty state on first load.
  • Stale lock recovery can delete a newly acquired live lock when multiple suites contend. — replaced with a transaction-scoped PostgreSQL advisory lock.

Reviewed dfd4138

@roomote-roomote

roomote-roomote Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the latest lock-recovery review chain (original finding, follow-up race) in dfd4138. Filesystem leases were removed; shared settings suites now use a transaction-scoped PostgreSQL advisory lock with database-owned atomic contention and automatic release. Four shared settings suites passed 67/67, web type checking and scoped lint passed, and pre-push gates passed. GitHub CI run 34477823324 completed successfully for exact SHA dfd4138f5d8524af22ac998f30e20890a0bb7655; its Test job passed unit and release-script tests. The review thread was replied to and resolved. Refreshed mixed-row desktop/mobile proof remains outstanding and is not claimed here.

</span>
</>
}
actions={

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action set no longer includes the task-history link: the historyFilter calculation and its link were removed, with no replacement in the new list. Custom-automation owners can now see only a relative “Last run” timestamp and cannot open their prior runs from this page. Keep the filtered task-history action so the refactor preserves that workflow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bruno clarified the intended right-side action set as Run now, Configure, and Delete only for custom automations. The history action is therefore intentionally omitted from this list rather than restored; the thread is left unresolved as a documented scope decision.

@brunobergher
brunobergher marked this pull request as ready for review September 10, 2026 11:51
Comment thread apps/web/src/testing/exclusive-automation-settings-database-lock.ts Outdated
@brunobergher
brunobergher merged commit e30cc68 into develop Sep 10, 2026
17 checks passed
@brunobergher
brunobergher deleted the feature/unified-automations-list-0pfjzocqemkvn branch September 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants