Skip to content

[Improve] Make guided agent interactions reliable - #2473

Merged
brunobergher merged 23 commits into
developfrom
feature/guided-interactions-2hkp457mhpgoz
Sep 11, 2026
Merged

[Improve] Make guided agent interactions reliable#2473
brunobergher merged 23 commits into
developfrom
feature/guided-interactions-2hkp457mhpgoz

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Add optional setup discovery for supported document, monitoring, and project-tracking integrations, with curated matching, secure configuration dialogs, skip/reorder support, and automatic continuation when nothing matches.
  • Make guided input durable and replay-safe: persist stable option IDs with label compatibility, record the responding human, keep responses in transcript chronology, suppress duplicate successful tool rows, and preserve failed rows.
  • Reconcile setup state and canonical receipts idempotently across live execution and queue recovery so saved answers, starter choices, and completed setup cards continue reliably without duplicate turns.
  • Share effective integration status and cache invalidation across setup and Settings so connection/configuration changes refresh availability and Fast tool discovery.
  • Harden Discord guided-input callbacks with stronger request tokens, active reply-target checks, and safe rebinding across snapshot resumes; document the optional integration flow.
  • Replay the exact 21-commit guided-interaction patch series directly onto current develop, preserving all eight Bruno-authored commits and removing unrelated release/hotfix ancestry.
  • Correct two stale DB test fixtures exposed by the exact-head CI run: invalid declarative YAML now omits the required name, and concurrent provider probes receive independent mocked responses.

Why this change was made

Guided setup could lose or misattribute answers, duplicate transcript activity, strand saved responses before continuation, and show stale integration availability. The branch also carried unrelated release and hotfix ancestry that obscured the actual review scope, while uncached DB execution exposed test fixtures that no longer matched current behavior or concurrency.

Impact

Guided interactions remain coherent across reloads, retries, concurrent submissions, recovery, and supported chat surfaces, while optional integration discovery stays non-blocking. The PR now contains 23 commits and 88 changed files relative to develop: 21 patch-equivalent guided-interaction commits plus two one-line DB test corrections.

The complete DB suite passes on a newly created test database (779/779). The previously failing StepAuthEnvVars.client.test.tsx test passes locally (18/18), the full web client suite passes (2,534/2,534), and lint, fast type checks, Knip, formatting, and pre-push gates pass. All substantive exact-head GitHub checks pass, including Test and Roomote code review, with every review thread resolved on 5340f39c8525665fc4ae2cd4b947fba1e97eecd8.

Authenticated browser behavior and external OAuth completion were not revalidated during this history and test-isolation cleanup; no browser or OAuth proof is claimed.

@roomote-community

roomote-community Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • packages/sdk/src/server/lib/fast-agent-parent-event.ts:2530 Durable setup-turn recovery schedules continuation after zero-match discovery.
  • apps/web/src/trpc/commands/fast-sessions/index.ts:977 Structured responses persist the submitting user's identity.
  • apps/worker/src/mcp/roomote-mcp-server/user-personalization.ts:18 Opt-out or rejected learning attempts are recorded as successful personalization updates. — dismissed: no longer changed by this PR.
  • packages/cloud-agents/src/server/user-personalization.ts:85 Runtime instructions apply private preferences to code and deliverables despite the documented conversation-only scope. — dismissed: no longer changed by this PR.

Reviewed 5340f39

Comment thread apps/web/src/trpc/commands/fast-sessions/index.ts
@roomote-roomote

roomote-roomote Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the requested findings through 006ca45: zero-match discovery schedules the next setup turn in live and durable-recovery paths, and canonical responses persist the actual submitting user. The specifically linked failed check belongs to duplicate PR #2475; its additional run-scoped cleanup and setup-collaboration findings are also fixed, all related threads are resolved, and its checklist reflects the final state. #2473’s current Roomote review passed with no code issues. Focused web and SDK suites plus repository pre-push gates passed; browser/OAuth proof remains unavailable.

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 10, 2026 17:29
@brunobergher
brunobergher force-pushed the feature/guided-interactions-2hkp457mhpgoz branch from 07aad30 to 601dcdf Compare September 11, 2026 15:44
Comment thread apps/worker/src/mcp/roomote-mcp-server/user-personalization.ts
Comment thread packages/cloud-agents/src/server/user-personalization.ts
@roomote-roomote
roomote-roomote Bot force-pushed the feature/guided-interactions-2hkp457mhpgoz branch from 601dcdf to 72d3b72 Compare September 11, 2026 16:18
@roomote-roomote
roomote-roomote Bot changed the base branch from main to develop September 11, 2026 16:18
@roomote-roomote
roomote-roomote Bot force-pushed the feature/guided-interactions-2hkp457mhpgoz branch 2 times, most recently from a74ca42 to 626f99a Compare September 11, 2026 16:22
@roomote-roomote

roomote-roomote Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Cleaned the existing PR branch through 5340f39c: all 21 guided-interaction patches and eight Bruno-authored commits are preserved on current develop, unrelated release/hotfix ancestry is gone, and the two DB test fixtures exposed by uncached CI execution are corrected. The PR now has 23 commits and 88 changed files; Test, Roomote code review, and every other substantive exact-head check pass, and all review threads are resolved.

@roomote-roomote
roomote-roomote Bot force-pushed the feature/guided-interactions-2hkp457mhpgoz branch from dd62715 to dd1b025 Compare September 11, 2026 17:06
@roomote-roomote
roomote-roomote Bot force-pushed the feature/guided-interactions-2hkp457mhpgoz branch from dd1b025 to 5340f39 Compare September 11, 2026 17:28
@brunobergher
brunobergher merged commit b1425cf into develop Sep 11, 2026
19 checks passed
@brunobergher
brunobergher deleted the feature/guided-interactions-2hkp457mhpgoz branch September 11, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants