Skip to content

DEV: update linters - #158

Merged
Alteras1 merged 2 commits into
mainfrom
dev/lint
Sep 18, 2026
Merged

Alteras1 merged 2 commits into
mainfrom
dev/lint

Conversation

@Alteras1

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Several API initializers pass the callback without the required unique initializer name, preventing them from running.

Pull request overview

Updates linting/tooling configuration and migrates BBCode administration to newer Discourse routing and initializer conventions.

Changes:

  • Adds and updates ESLint, Stylelint, Prettier, TypeScript, and package scripts.
  • Modernizes CSS and JavaScript formatting.
  • Migrates the admin reset page, routing, and initializer integrations.
File summaries
File Summary
tsconfig.json Adds TypeScript configuration.
stylelint.config.mjs Adds Stylelint configuration.
plugin.rb Updates admin routing.
package.json Updates tooling and scripts.
eslint.config.mjs Extends ESLint ignores.
config/routes.rb Changes refresh endpoint to authenticated POST.
config/locales/client.en.yml Removes obsolete translation.
assets/stylesheets/common/textmessage.scss Modernizes formatting and syntax.
assets/stylesheets/common/tabs.scss Modernizes formatting and syntax.
assets/stylesheets/common/spoiler.scss Modernizes formatting and syntax.
assets/stylesheets/common/size.scss Modernizes formatting and syntax.
assets/stylesheets/common/side.scss Modernizes formatting and syntax.
assets/stylesheets/common/rowcolumn.scss Modernizes formatting and syntax.
assets/stylesheets/common/print.scss Modernizes formatting and syntax.
assets/stylesheets/common/ooc.scss Modernizes formatting and syntax.
assets/stylesheets/common/note.scss Modernizes formatting and syntax.
assets/stylesheets/common/newspaper.scss Modernizes formatting and syntax.
assets/stylesheets/common/markdown-shims.scss Modernizes formatting and syntax.
assets/stylesheets/common/mail.scss Modernizes formatting and syntax.
assets/stylesheets/common/index.scss Modernizes formatting and syntax.
assets/stylesheets/common/imagefloat.scss Modernizes formatting and syntax.
assets/stylesheets/common/heightrestrict.scss Modernizes formatting and syntax.
assets/stylesheets/common/fieldset.scss Modernizes formatting and syntax.
assets/stylesheets/common/divide.scss Modernizes formatting and syntax.
assets/stylesheets/common/border-bg.scss Modernizes formatting and syntax.
assets/stylesheets/common/blockquote.scss Modernizes formatting and syntax.
assets/stylesheets/common/block.scss Modernizes formatting and syntax.
assets/stylesheets/common/accordion.scss Modernizes formatting and syntax.
assets/javascripts/lib/discourse-markdown/bbcode-plugin.js Applies formatting updates.
assets/javascripts/discourse/templates/admin/plugins-bbcode.hbs Updates admin template structure.
assets/javascripts/discourse/initializers/bbcode-admin-plugin-configuration-nav.js Updates admin navigation.
assets/javascripts/discourse/bbcode-route-map.js Updates admin route mapping.
assets/javascripts/discourse/api-initializers/spoiler.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/inlinespoiler.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/highlight.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/google-font.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/fontawesome.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/class.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/bbscript.js Migrates API initializer.
assets/javascripts/discourse/api-initializers/accordion.js Migrates API initializer.
app/controllers/bb_code/admin/refresh_controller.rb Updates refresh responses.
admin/assets/javascripts/discourse/templates/admin-plugins/show/bbcode-reset.gjs Adds the reset page template.
admin/assets/javascripts/discourse/controllers/admin-plugins/show/bbcode-reset.js Adds reset state and POST handling.
.vscode/settings.json Removes editor-specific settings.
.vscode/extensions.json Removes extension recommendations.
.template-lintrc.cjs Removes obsolete template-lint configuration.
.prettierrc.cjs Uses shared Prettier configuration.
.prettierignore Removes obsolete ignore entries.
.npmrc Updates package manager settings.
.husky/pre-commit Removes obsolete pre-commit hook.
.husky/.gitignore Removes obsolete Husky configuration.
.gitignore Ignores ESLint cache files.
.editorconfig Removes editor configuration.
Review details

Suppressed comments (8)

assets/javascripts/discourse/api-initializers/accordion.js:178

  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/bbscript.js:146
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/class.js:33
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/fontawesome.js:6
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/google-font.js:48
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/highlight.js:342
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/inlinespoiler.js:25
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Supply a unique name before the callback.
    assets/javascripts/discourse/api-initializers/spoiler.js:136
  • apiInitializer requires the initializer name as its first argument; passing the callback as the first argument leaves the initializer without a valid callback/name and prevents this initializer from running. Keep the existing behavior by supplying a unique name before the callback.
  • Files reviewed: 49/55 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Alteras1

Copy link
Copy Markdown
Collaborator Author

@copilot discourse should already be auto generating names for initializers in api-initializers

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown

@copilot discourse should already be auto generating names for initializers in api-initializers

Agreed. In Discourse, API initializers in api-initializers already receive generated unique names, so no code change is needed here.

@Alteras1
Alteras1 merged commit 3e4b20d into main Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants