Repository navigation
FIX: Contain and rehost bbcode CSS injection - #163
Merged
Merged
Conversation
This change extends core's `HotlinkedMedia`/`PostHotlinkedMedia` pipeline (via a plugin-local prepend, no core changes) to also discover and download CSS `url()` references, rewrites both `post.cooked` and `post.raw` to point at the resulting local upload the same way core does for images, and resolves leftover `upload://` references client-side so the composer preview renders correctly too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, CSS injected via
[bg]/[class]/rawstyle=""attributes could escape the post to cover the viewport withposition: fixedelements, andurl()values could point at arbitrary external hosts, so viewing a post silently issued a request to that host on every page load.This change makes
.cooked/.d-editor-previewa containing block viacontain: layoutand clips overflow withclip-path, and extends core'sHotlinkedMedia/PostHotlinkedMediapipeline (via a plugin-local prepend, no core changes) to rehost CSSurl()references the same way core already rehosts<img>/<a>uploads.