Add support for exact division#1256
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 90.91% 90.99% +0.08%
==========================================
Files 188 189 +1
Lines 21965 22139 +174
==========================================
+ Hits 19969 20146 +177
+ Misses 1996 1993 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This just needs to be rebased on #1257 which is a separate issue. |
eecaff2 to
aab40f1
Compare
aab40f1 to
4b0561a
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
4b0561a to
dc7f7f5
Compare
tarcieri
reviewed
May 12, 2026
tarcieri
reviewed
May 12, 2026
tarcieri
reviewed
May 12, 2026
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
tarcieri
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
div_exactanddiv_exact_vartimemethods forUint,BoxedUint, andLimb. There is currently no trait support.For cases where it applies, exact division can be much faster than div/rem. In my tests this is about 40% faster for a 4096-bit
BoxedUint.The algorithm is similar to
DivideByWordin Modern Computer Arithmetic but I don't have a reference for the adjustments to support a multi-word divisor.