ghash: add FieldElement - #356
Merged
Merged
Conversation
Contributor
Author
|
@tarcieri tried to implement #[inline(always)]
fn convert(x: u128) -> u128 {
x.reverse_bits().swap_bytes()
}
#[inline(always)]
fn convert_block(block: &Block) -> Block {
convert(u128::from_le_bytes((*block).into()))
.to_le_bytes()
.into()
}Because STB spec works in different notation. |
Member
|
Heh, I had a half-finished version of this locally too, but we can go with this.
Wait, it uses GHASH, but in little endian? Weird. Unfortunate they didn't use POLYVAL if they wanted little endian. |
tarcieri
reviewed
Aug 28, 2026
tarcieri
reviewed
Aug 28, 2026
Contributor
Author
Yeah, unfortunately :( |
tarcieri
reviewed
Aug 28, 2026
tarcieri
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#355