Update actions/setup-node action to v7 - #130
Conversation
|
This update standardizes the CI workflows by upgrading the Node setup action to the latest v7.0.0, ensuring consistency across build and code‐quality checks without affecting end‐user functionality. Walkthrough
Model: o4-mini-2025-04-16 | Prompt Tokens: 784 | Completion Tokens: 565 |
There was a problem hiding this comment.
I have prepared a supportive review of your code with AI assistance. Please view these observations as helpful ideas rather than fixed rules. Feel welcome to adopt whatever aligns best with your approach. You remain at the helm of every choice and AI is here to back your decisions.
Model: o4-mini-2025-04-16 | Prompt Tokens: 1299 | Completion Tokens: 3325
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version-file: source-folder/.tool-versions | ||
| cache: npm |
There was a problem hiding this comment.
Consider pinning to the semantic version tag instead of a full SHA to make future minor/patch updates easier to adopt. For example:
- name: Setup Node (PR Summary)
uses: actions/setup-node@v7
with:
node-version-file: source-folder/.tool-versions
cache: npm| - name: Setup Node (PR Review) | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version-file: source-folder/.tool-versions | ||
| cache: npm |
There was a problem hiding this comment.
These two setup-node invocations share identical configuration. You could DRY this up by creating a reusable composite action (e.g. .github/actions/setup-node.yaml), then call it in both places. For example:
# .github/actions/setup-node.yaml
name: "Setup Node"
runs:
using: composite
steps:
- uses: actions/setup-node@v7
with:
node-version-file: source-folder/.tool-versions
cache: npmAnd in your workflow:
- name: Setup Node (PR Review)
uses: ./.github/actions/setup-node.yaml| - name: Setup Node | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version-file: .tool-versions |
There was a problem hiding this comment.
Similarly to the other workflow, switch to the semver tag for actions/setup-node for readability and easier maintenance:
- name: Setup Node
uses: actions/setup-node@v7
with:
node-version-file: .tool-versions
cache: npm| - name: Checkout source branch | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version-file: .tool-versions | ||
| cache: npm |
There was a problem hiding this comment.
It looks like you have duplicate Checkout source branch and Setup Node steps here. You can remove the redundant block or, better yet, factor out the setup into a single reusable step. This will keep the workflow concise and avoid unnecessary duplication.
This PR contains the following updates:
v6.4.0→v7.0.0Release Notes
actions/setup-node (actions/setup-node)
v7.0.0Compare Source
What's Changed
Enhancements:
Bug fixes:
mirrorTokeningetManifestif it's provided by @deiga in #1548Documentation updates:
Dependency update:
New Contributors
Full Changelog: actions/setup-node@v6...v7.0.0
v6.5.0Compare Source
What's Changed
Full Changelog: actions/setup-node@v6.4.0...v6.5.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.