chore: Add twoslash to test code snippets for correctness - #596
Merged
Conversation
marikaner
force-pushed
the
doctest
branch
2 times, most recently
from
July 22, 2026 07:12
0761a96 to
b5bcac6
Compare
InjunPark-sap
requested changes
Jul 28, 2026
InjunPark-sap
previously approved these changes
Aug 3, 2026
Co-authored-by: Injun Park <injun.park@sap.com>
Co-authored-by: Injun Park <injun.park@sap.com>
davidkna-sap
approved these changes
Aug 4, 2026
davidkna-sap
previously approved these changes
Aug 4, 2026
* chore: string twoslash cuts manually * add changes from review * add other notation * rename plugin * wip * rename mjs => js * fix name * oops
InjunPark-sap
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, that there were around 30 actual errors in the code samples, that are solved by this PR.
Also note, I forgot to mention this in the review: To have the latest version of the SDK available I am using the canary versions of the AI SDK. As they cannot be updated by dependabot due to the nature of pre versions, I created an additional workflow that runs nightly. This could be changed to: