fix(publish): declare public npm access for the migrated packages - #640
Open
jacob-kreyenbuehl wants to merge 1 commit into
Open
jacob-kreyenbuehl wants to merge 1 commit into
jacob-kreyenbuehl wants to merge 1 commit into
Conversation
`.changeset/config.json` sets `access: "restricted"`, and `changeset publish` falls back to that value for any scoped package that does not declare `publishConfig.access`. The `@sap-devx/inquirer-gui` packages and `@sap-devx/webview-rpc` were migrated without the field, so their next publish would run `npm publish --access restricted` against packages that are already public on npm. Declare `publishConfig.access: "public"` on all 11, matching the other 20 published scoped packages in the workspace. Signed-off-by: Jacob Kreyenbuehl <jacob.kreyenbuehl@sap.com>
Contributor
Build ReportPlease note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
publishConfig.access: "public"to the 11 migrated scoped packages that were missing it: the 10@sap-devx/inquirer-gui*packages and@sap-devx/webview-rpc.Why
.changeset/config.jsonsetsaccess: "restricted", andchangeset publishuses that value whenever a package has nopublishConfig.access(access: publishConfig?.access || access). So these 11 would runnpm publish --access restrictedagainst packages that are already public on npm. That fails.I found this while diagnosing the red Release run after #639 (run 36707398978). Publish stopped with 24x
404 Not Found - PUT. The 404 is a separate npm problem: the trusted publishers of the migrated scopes still point at their old repos (@sap_oss/task_contrib_types->SAP/task-explorer,@xml-tools/*->sap/xml-tools,@sap-devx/inquirer-gui*->SAP/inquirer-gui, and so on). This PR fixes the other half, which would fail immediately after that one is fixed.Behaviour
Public packages stay public when published from the monorepo. The other 20 published scoped packages already declare this, and #582 added it for
vsix-zst.Not in this PR: the trusted-publisher retarget, which is npm side and needs owner access. Both have to land before the next publish attempt, because
changeset publishaborts if any single package fails.