fix: rename subaccount id attribute - #268
Merged
Merged
Conversation
LucasAlvesSoares
marked this pull request as ready for review
August 12, 2026 23:22
NicoleMGomes
approved these changes
Aug 12, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Renames the OpenTelemetry resource attribute
sap.cld.subaccount_idtosap.cloud.provider.subaccount_idto align with the canonical SAP cloud attribute naming convention.Changed files:
src/sap_cloud_sdk/core/telemetry/constants.py— updated theATTR_SAP_SUBACCOUNT_IDstring valuesrc/sap_cloud_sdk/core/telemetry/config.py— updated the corresponding docstringAll usages reference the
ATTR_SAP_SUBACCOUNT_IDconstant, so no other call sites required changes.Related Issue
Type of Change
Please check the relevant option:
How to Test
pytest tests/core/unit/telemetry/sap.cloud.provider.subaccount_idinstead ofsap.cld.subaccount_idChecklist
Before submitting your PR, please review and check the following: