fix(extensibility): update a2a-sdk Message serialization for protobuf-based types - #270
Open
rishikunnath2747 wants to merge 2 commits into
Open
fix(extensibility): update a2a-sdk Message serialization for protobuf-based types#270rishikunnath2747 wants to merge 2 commits into
rishikunnath2747 wants to merge 2 commits into
Conversation
Replace model_dump/Message(**kwargs) with protobuf-compatible MessageToDict/ParseDict and bump a2a-sdk lower bound to >=1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
a2a-sdk >= 1.0changeda2a.types.Messagefrom a Pydantic model to a protobuf-generated type. This broke two call sites inextensibility/client.py:message.model_dump(mode="json")— protobuf has no.model_dump(), causing a silent warning and empty message bodyMessage(**response_json)— protobuf constructor rejects camelCase keys, silently dropping all fields from the hook responseReplaced with
google.protobuf.json_format.MessageToDictandParseDictrespectively. Also bumped thea2a-sdklower bound to>=1.0.0.Type of Change
How to Test
a2a-sdk>=1.0.0Messagefields are correctly populated (previously all fields were silently dropped)Checklist