fix(chat): don't reopen completed turns for trailing goal updates - #547
Merged
Conversation
- Exclude plan and goal items from live assistant activity in runtimeEventReducer so trailing updates don't restart a completed turn - Extract WorkedFor/WorkingFor rendering in ChatTurnElapsed so the elapsed timer stops ticking once the turn ends - Add tests covering both behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goalandplanitem events arriving after a GUI turn finishes no longer reopen that turn in runtime state.runtimeEventReducer.tsnow treatsplan/goalitems as non-live activity, so they can't reactivate a completed turn or restart its elapsed timer.ChatTurnElapsedto render the completed "Worked for N" duration declaratively in the same commit instead of mutatingtextContent, preventing the timer from ticking again after the turn ends.