Repository navigation
Improve warnings and invalid values for systemd - #572
Merged
Merged
Conversation
Unit Test Results (grammar engine true)1 917 tests 1 917 ✅ 1m 15s ⏱️ Results for commit db9fc63. |
Unit Test Results (grammar engine false)1 917 tests 1 917 ✅ 1m 23s ⏱️ Results for commit db9fc63. |
Add warnings (not errors) for values systemd still accepts but warns about, so they are no longer silently treated as fine: - StandardOutput=/StandardError= syslog and syslog+console (obsolete, systemd uses journal / journal+console) - the "!!" prefix on Exec*= lines (no longer supported, ignored) - unknown escape sequences in Exec*= arguments (systemd keeps the backslash and logs a warning) - PIDFile= and socket paths under /var/run (systemd rewrites to /run) - KillMode=none (unsafe) - User=nobody and SocketUser=nobody (systemd logs "not safe" at notice level, so this one is a weak warning) - Address=/Peer= without a prefix length, and unmasked AllowedIPs= - deprecated boolean forms of IPMasquerade= and IPv4LL= Each message says what systemd does and what to write instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
) Values that systemd's parser accepts but that are rejected or dropped at unit or container start are errors again: - unknown RestrictFileSystems= filesystem names (dropped by the BPF restrict-fs code, so the entry neither allows nor denies anything) - nspawn Bind=/BindReadOnly= with unknown mount options (container fails to start) - nspawn AmbientCapability=all (refused by systemd-nspawn) - traffic-control limits networkd refuses (e.g. ETS bands above 15, GRED and Xfrm limits) nspawn SystemCallFilter= entries with "~" after the first word are silently ignored by systemd-nspawn and now get a warning. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sjrx-claude-sandbox
force-pushed
the
feat/565-severity
branch
from
October 27, 2026 23:22
db9fc63 to
21d5d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.