test(lang-models): raise browser Mocha timeout to 60s for the micrograd demo#703
Merged
Merged
Conversation
…rograd demo MicrogradMoonsDemoTest trains a 200-epoch moons MLP; in a browser engine (especially wasmJs under CI/parallel load) the run can exceed Mocha's 2s default before the computation finishes — the test computes the correct result (loss 0.082, accuracy 0.85) but the harness times out. 10s was not always enough under contention; 60s gives headroom on both js and wasmJs browser targets. Verified: :skainet-lang-models:wasmJsBrowserTest + jsBrowserTest green (1/1 each).
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicrogradMoonsDemoTest.micrograd_moons_demo_trains_and_classifiesflaked on the wasmJs-browser target underallTests(parallel load) with Mocha's defaultTimeout of 2000ms exceeded. The test isn't broken — its system-out shows it trained all 200 epochs (loss=0.082) and hitaccuracy 0.85 (17/20), identical to jvm / native / jsBrowser / wasmWasi. It just ran slower than the harness allowed under contention.The module already set
useMocha { timeout = "10s" }(since 0.19.0), but that wasn't always enough — this raises it to 60s for bothjsandwasmJsbrowser test tasks.Surfaced now because browser tests only run when
CHROME_BINis set; without it they skip/fail-to-launch, so this slow test was never actually executed in the browser before.Verified:
:skainet-lang-models:wasmJsBrowserTest+jsBrowserTestgreen (1/1 each) with the bump.