Feature/advancement sync - #26
Open
janhoeck wants to merge 22 commits into
Open
Conversation
Design for syncing player advancements from <world>/advancements/<uuid>.json alongside the existing statistics path: three new tables in the microservice, full-snapshot replace per (player, server), no history. Triggered on quit, world save and shutdown. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Tables are created manually by the operator. nativeUuid maps to the native UUID type on Postgres, and indexes move out of CREATE TABLE. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Eleven TDD tasks covering API models, file parsing, change detection, microservice tables and persistence, and the Paper trigger points. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pre-flight ruling: flushPlayerAdvancements would have duplicated flushPlayerStats verbatim. Both now go through flushViaReflection with an accessor name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The convention plugin declares surf-api-core as compileOnly only, so key() and logger() never reach testCompileClasspath. Found while implementing task 1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Instant.parse accepts arbitrary offsets since JDK 12, so the offset test was satisfied by the second strategy and the OffsetDateTime branch had no coverage. Split into an offset-instant case and a second-less case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The flag was copied from StatsFileServiceImpl and silently replaces a JSON null for criteria/done with the property default, so a malformed entry was accepted instead of skipped and logged. Contradicted the plan's own global constraint. Test added for both null fields. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Addresses reviewer finding: coerceInputValues flag silently converts null values to defaults instead of throwing, which contradicts the global constraint that malformed entries must be skipped and logged. Removing this flag ensures entries with null criteria or done fields are properly rejected. Adds test case covering entries with null criteria or done fields.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.