Skip to content

fix: unify query keys, network scope, and cancellation - #807

Merged
IbrahimIjai merged 3 commits into
SO4-Markets:mainfrom
DeSaint007:combined-desaint-query-cache
Sep 26, 2026
Merged

IbrahimIjai merged 3 commits into
SO4-Markets:mainfrom
DeSaint007:combined-desaint-query-cache

Conversation

@DeSaint007

Copy link
Copy Markdown

Summary

This PR consolidates the four assigned DeSaint007 query-cache issues into one reviewable change set.

  • OB-101: Establish a canonical query-key factory #756 — Canonical query-key factory

    • adds one canonical factory for public/account-scoped network, venue, market, account, filter, pagination, timeframe, and source identity
    • documents the migration map from the existing registries
    • adds prefix/scope-isolation coverage so optional filters cannot alias distinct requests
  • OB-102: Remove hardcoded network identity from cache and event paths #757 — Network identity in cache/event paths

    • removes hardcoded network identity from affected trade/order-event paths
    • derives execution/query identity from the active network configuration
    • keeps RPC and indexer source identities distinct
  • OB-103: Migrate existing query producers and invalidators together #758 — Producer/invalidation migration

    • migrates trade, wallet, indexer, pools, earn, faucet, referral, and landing consumers to the canonical families
    • updates representative invalidators alongside their producers
    • avoids broad QueryClient clears and preserves unrelated account/market caches
  • OB-104: Propagate cancellation and reject obsolete responses #759 — Cancellation and obsolete-response guards

    • propagates TanStack Query abort signals through supported fetch/GraphQL adapters
    • guards non-abortable paths against writes after market/account context changes
    • keeps cancellation separate from user-visible error reporting
    • migrates the newer cancel-order invalidation path onto the same canonical keys

Verification

The complete ordered repository gate and required integration checks pass on this branch:

  • bun run changelog:validate
  • bun lint
  • bun typecheck
  • bun run check:tokens
  • bun run check:content
  • bun run test
  • bun run test:coverage
  • bun run build
  • indexer codegen/build/test
  • local contract sync + manifest validation
  • web typecheck + production build

Final gate completed with FINAL_DESAINT_GATE_OK.

Closes #756
Closes #757
Closes #758
Closes #759

Unify query-key identity across RPC and indexer reads, remove hardcoded network cache identity, migrate producers and invalidators together, and propagate cancellation to supported transports. Also repairs existing web gate blockers required by the repository commit policy.
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@Ay-obami is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 25, 2026

Copy link
Copy Markdown

@DeSaint007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai
IbrahimIjai merged commit 0ae6166 into SO4-Markets:main Sep 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants