Fix replacement in attached Postgres catalogs - #6078
Open
clowrance-proppilot wants to merge 1 commit into
Open
clowrance-proppilot wants to merge 1 commit into
clowrance-proppilot wants to merge 1 commit into
Conversation
Signed-off-by: clowrance-proppilot <clowrance@propertypilot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DuckDB does not support
CREATE OR REPLACE TABLEfor tables in an attached Postgres catalog. SQLMesh currently selects replacement behavior using the current DuckDB catalog rather than the target table catalog, so a full refresh of an attached Postgres table attempts unsupported DDL. It also fails when the physical table has dependent SQLMesh virtual-layer views.This change:
DROP TABLE IF EXISTS ... CASCADEfollowed by the normal create pathSQLMesh recreates the virtual-layer views after physical model evaluation, so cascading those dependencies matches the full-refresh lifecycle.
Related context:
This PR addresses physical table replacement in an attached Postgres catalog; it does not claim to close #5438 by itself.
Test Plan
make stylemake fast-testpytest tests/core/engine_adapter/test_duckdb.py -qChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO