Radio bridge connection states#389
Merged
Merged
Conversation
Contributor
|
Seems good to me. Should lay the ground work for time sync as well if we need that at some point. |
Contributor
|
I'm okay with the code. Do you wanna test on main first or nah? |
Contributor
Author
I'm confident enough especially with the improved launch tests passing. |
Merged
chachmu
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivating change here was adding the initial connection timeout feature that @guyfleeman had prototyped. Rather than continue to accrue boolean arrays that track the connection lifecycle going forward, I've added the
ConnectionStateenum where we can add as many states as we want and keep it in one array.While I was poking around, I decided to update the launch tests in this package so they would catch bugs like the goodbye message bug fixed in #385 . I also turned on warnings as errors for this package as a prep step for the more substantial changes coming to support the new control scheme. Oh, and I made the plural-ish-ness of some variable names more consistent.