Clearer PR example screenshots, and add Puppeteer to the tooling list - #13281
Closed
isaaclombardssw wants to merge 2 commits into
Closed
Clearer PR example screenshots, and add Puppeteer to the tooling list#13281isaaclombardssw wants to merge 2 commits into
isaaclombardssw wants to merge 2 commits into
Conversation
The demo PR only changed the hover border, so the before/after pair was hard to read at a glance. It now changes the card title colour too. Renamed the images so nothing serves the cached old pair. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
🔍 Preview PR ChangesView updated pages in edit mode:
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
isaaclombardssw
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the rule.
Clearer PR example screenshots. The demo PR behind the good/bad examples only changed the card hover border, so the before/after pair was hard to read at a glance. The demo now changes the card title colour as well, so black vs red is obvious in the screenshot. Recaptured both PR pages and renamed the image files, since reusing the old names risks serving the cached pair.
Demo PRs: #5012 and #5013.
Added Puppeteer to the tooling list. Steel was already there. Puppeteer is worth naming for projects that already use it and do not want a second browser stack.
🤖 Generated with Claude Code