fix: resolve markdown formatting and links rendering issues - closes #2707 - #2708
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
- Add support for bold markdown (**text**) in figure captions alongside existing link parsing - Add markdown support for YouTube video descriptions (bold and link formatting) - Apply same markdown parsing to YouTubeShorts component - Fixes bold asterisks being displayed as raw text and links appearing as raw URLs Closes #2707 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users reported rendering issues on the "Tick and Flick" rule page:
**) was being displayed alongside already bolded text instead of being properly parsedThe issue appeared multiple times on the rule and affected both figure captions and video descriptions.
Solution
Enhanced markdown parsing in two key components:
1. Figure Component (
components/embeds/figure.tsx)renderFigureText()to handle bold markdown syntax (**text**) in addition to existing link parsing**text**to<strong>HTML elements[text](url)alongside bold formatting2. YouTube Components (
components/shared/Youtube.tsx)renderMarkdownDescription()helper function to parse markdown in video descriptionsYouTubePlayerandYouTubeShortscomponents to use the new markdown rendererTechnical Details
Both components now follow the same markdown parsing pattern:
[text](url)using regex capture groups**text**<a>for external,<strong>for bold,<span>for plain text)This ensures that:
Testing Recommendations
**characters)