Add signal-color variants to Badge, rename destructive to danger - #172
Merged
Merged
Conversation
oharsta
marked this pull request as draft
September 10, 2026 09:45
Mirrors the Alert component's signal-color work: info/success/warning/ danger variants styled as a subtle tint (bg-<name>-subtle / text-<name>-subtle-foreground), per the Figma Badge spec (node 29163:153619). destructive is renamed to danger for naming parity with Alert; other existing variants (secondary/outline/ghost/ link) are untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
oharsta
changed the title
oharsta
marked this pull request as ready for review
September 10, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
info/success/warning/dangervariants added to Badge, styled as a subtle tint (bg-<name>-subtle/text-<name>-subtle-foreground), per the Figma Badge spec (node 29163:153619, "Subtle=True" state).destructiveis renamed todangerfor naming parity with Alert's earlier rename.secondary,outline,ghost,link) are left untouched, per instruction.border-subtleopacity 0.08 → 0.06 across several brand themes) that was already on this branch.minorchangeset for@surfnet/curve-react,@surfnet/curve-angular,@surfnet/curve-contracts.Test plan
pnpm lint/pnpm buildpass in both packages.Variants,Status Liststories) — colors match the Figma spec exactly, in both React and Angular.client/usages of Badge'sdestructivevariant found (repo-wide grep), so no consumer follow-up needed