Skip to content

fix(web): remove automatic resume polling - #138

Merged
SuPuHe merged 1 commit into
developfrom
fix/session-details-resume-result
Sep 13, 2026
Merged

SuPuHe merged 1 commit into
developfrom
fix/session-details-resume-result

Conversation

@SuPuHe

@SuPuHe SuPuHe commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a dedicated wallet-address copy action and align the wallet address styling with the session DID.
  • Remove the non-working Resume result UI action and all automatic job-status polling that produced repeated network requests.
  • Keep supplier delivery state explicit: Result ready is shown only when the job contains an actual supplier result.
  • Use the existing manual Refresh requests action to observe a later supplier delivery update.
  • Preserve the no-new-payment recovery and payment-proof invariants.

Scope and acceptance criteria

  • Wallet address is separated, styled like the DID, and copied in full.
  • The web UI sends no POST /v1/jobs/:jobId/resume from the Requests list.
  • The web UI sends no automatic GET /v1/jobs/:jobId polling requests.
  • A pending paid delivery remains visibly Retrieving result.
  • Result ready and the supplier report render only when the API returns job.result.
  • Settlement proof state is not misrepresented as supplier-result readiness.
  • Manual Refresh requests can observe a later AVAILABLE job.
  • No second payment, settlement, or supplier job is created.
  • Browser acceptance mocks model PENDING first and AVAILABLE after manual refresh.

Product and security invariants

  • No settlement or payment path was changed.
  • Payment proof remains read-only.
  • A committed settlement is not treated as proof that a supplier report exists.
  • No secrets, credentials, production identifiers, or personal data are committed.

Validation

pnpm --filter @oneshot/web test - PASS (17 files, 95 tests)
Focused web tests - PASS (22 tests)
pnpm --filter @oneshot/web lint - PASS
pnpm --filter @oneshot/web typecheck - PASS
pnpm --filter @oneshot/web test:browser - PASS (8 tests)
pnpm format:check - PASS
git diff --cached --check - PASS

Independent review evidence

Gate A

  • Verdict: VERDICT: PASS
  • Reviewer tool: free-pi-cli
  • Reviewer model: deepseek-v4-flash
  • Reviewed base: develop (d671af1da36878b7aaafcfc3049bc958e0daeb34)
  • Reviewed target: fix/session-details-resume-result, staged workspace
  • Reviewed tree: 645ea94582c10dc119bd33ad057f95106e788a81
  • Blocking findings: None reported
  • Non-blocking findings: None reported with the supplied verdict

Gate B

  • Verdict: NOT RUN — intentionally deferred per user request.

Risk and rollback

  • Residual risk: If the supplier worker remains pending, the UI stays in retrieval state until a later manual refresh observes the completed delivery.
  • Rollback: Revert commit a2903a1e70ed1a2372893b36c76c6515f90cca78; no payment or settlement data migrations are involved.

Human merge

  • A human owner has reviewed the evidence and will perform the merge.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
oneshot a2903a1 Sep 13 2026, 01:42 PM

@SuPuHe
SuPuHe merged commit 65200cc into develop Sep 13, 2026
5 checks passed
@selezenart
selezenart deleted the fix/session-details-resume-result branch September 13, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant