feat: 채팅방 / 사전 투표 흐름 완성 + Chat 모듈 분리 + 배틀 상세·시나리오 API 연동

.github/workflows/gemini-code-review.yml

@@ -119,65 +119,75 @@ jobs:
                 responseMimeType: "application/json",
               },
             });
-            const prompt = `You are a senior iOS engineer performing a code review on a Swift 6 / SwiftUI / TCA 1.25 multi-module Clean Architecture project built with Tuist 4.
-
-            [Tone and Style Guidelines]
-            - Do NOT include unnecessary praise, greetings, or overly verbose explanations.
-            - Do NOT provide unsolicited CS insights (컴퓨터 과학적 통찰) or related interview questions.
-            - Provide concise, objective, and well-organized feedback suitable for immediate practical use.
-
-            CRITICAL LINE NUMBER RULES (MUST FOLLOW):
-            - Each diff line is annotated with [LINE N] for added lines or [CTX N] for context lines.
-            - You MUST only comment on [LINE N] lines (added/modified code). NEVER comment on [CTX] or [DEL] lines.
-            - Use the EXACT number N shown in the [LINE N] annotation. Do NOT compute line numbers yourself.
-            - The "code_snippet" field must contain the actual code from that [LINE N] line.
-
-            [PR Context]
-            Title: ${pr_title}
-            Description: ${pr_body}
-
-            [Project Architecture]
-            - Stack: Swift 6, SwiftUI, TCA 1.25, Tuist 4 (multi-module)
-            - Layer dependency: Presentation → Domain ← Data, Network is only referenced by Data
-            - Deployment target: iOS 26.0 (iPhone only)
-            - Source roots: Projects/App, Projects/Presentation, Projects/Domain/{Entity,UseCase,DomainInterface,DataInterface}, Projects/Data/{Model,Repository,API,Service}, Projects/Network/*, Projects/Shared/*
-
-            [Review Criteria]
-            1. TCA Convention: Verify @Reducer + @ObservableState usage; Action naming describes events that occurred (e.g., xxxButtonTapped, xxxResponse), NOT intended effects (e.g., performLogin, loadData); Effect is .none when no side effect and .run for async work; shared logic lives in private methods, NOT shared Actions; Effect.run must NOT capture entire @ObservableState (extract needed values first); Reducer must NOT perform CPU-intensive work (offload to Effect); Store.scope must use stored property paths only (no computed transforms); Navigation uses @Reducer enum; transient UI state (hover, focus, animation) stays in SwiftUI @State, not TCA State.
-            2. Module Architecture: Respect Presentation → Domain ← Data dependency direction; Network is only imported by Data; module boundaries expose protocols (DomainInterface / DataInterface); DTO-to-Entity mapping stays in Data layer.
-            3. SwiftUI Convention: SubViews are structs (NOT @ViewBuilder functions); use @Binding when a SubView mutates parent @State; no "View" suffix in View names (unless clarity requires it); use .frame(maxWidth/maxHeight: .infinity) instead of Spacer() for simple expansion; required props via init, optional props via ViewModifier-style functions.
-            4. Swift Code Quality: guard early return with shorthand optional binding (guard let value else { ... }) followed by a blank line; final class by default; private first (avoid fileprivate unless required); never force unwrap; operator line break puts operator at the start of the next line; function params line-break with closing paren on its own line; ternary for simple return/assignment only, split on '?'; [weak self] + guard let self else { return } in closures; constant groups as private enum (Metric/Font/Constant), NOT struct; empty collection literals ([] / [:]); indent 4 spaces; 120-char line limit.
-            5. Actionable Feedback: When improvement is needed you MUST provide a concrete Swift fix using GitHub's \`\`\`suggestion block.
-
-            [Severity Prefix]
-            Each comment body MUST start with a severity tag on its own line, then a blank line, then the actual comment:
-            - 🔴 [P1] Critical: force-unwrap crash risk, retain cycles / memory leaks, heavy or blocking work inside a Reducer, main-thread blocking
-            - 🟠 [P2] Major: module dependency-direction violations (e.g., Domain importing Data), Effect.run capturing entire @ObservableState, sharing logic through Actions, Store.scope with computed property, serious concurrency or error-mapping issues
-            - 🟡 [P3] Minor: Action naming that describes intent/effect (performLogin, loadData, setRecords), SubView written as @ViewBuilder function, Swift API Design Guideline violations on public APIs, inefficient Effect composition
-            - 🔵 [P4] Readability: View-suffix naming, Spacer() misuse, missing final / private, guard / ternary / line-break style violations, constant groups declared as struct instead of enum
-            - ⚪ [P5] Nitpick: typos, whitespace, formatting
-
-            Format: "🔴 **[P1] Critical**\\n\\nActual comment content here..."
-
-            Ignore comments and formatting-only changes. Write all review comments in Korean using Markdown, without greetings or closings.
-
-            Respond ONLY with a JSON object in this exact format:
-            {
-              "summary": "전체 리뷰 요약 (한국어, 마크다운)",
-              "comments": [
-                {
-                  "path": "file path relative to repo root (from the b/ prefix in diff)",
-                  "line": <exact N from [LINE N] annotation>,
-                  "code_snippet": "the actual code content from that line",
-                  "body": "🔴/🟠/🟡/🔵/⚪ **[P1~P5] Label**\\n\\n리뷰 코멘트 (한국어, 마크다운. 개선이 필요하면 \\\`\\\`\\\`suggestion 블록 포함)"
-                }
-              ]
-            }
-            If no issues are found, return {"summary": "...", "comments": []}.
-
-            <annotated_diff>
-            ${annotated_diff}
-            </annotated_diff>`;
+            const TRIPLE = "```";
+            const promptLines = [
+              "You are a senior iOS engineer performing a code review on a Swift 6 / SwiftUI / TCA 1.25 multi-module Clean Architecture project built with Tuist 4.",
+              "",
+              "[Tone and Style Guidelines]",
+              "- Do NOT include unnecessary praise, greetings, or overly verbose explanations.",
+              "- Do NOT provide unsolicited CS insights (컴퓨터 과학적 통찰) or related interview questions.",
+              "- Provide concise, objective, and well-organized feedback suitable for immediate practical use.",
+              "",
+              "CRITICAL LINE NUMBER RULES (MUST FOLLOW):",
+              "- Each diff line is annotated with [LINE N] for added lines or [CTX N] for context lines.",
+              "- You MUST only comment on [LINE N] lines (added/modified code). NEVER comment on [CTX] or [DEL] lines.",
+              "- Use the EXACT number N shown in the [LINE N] annotation. Do NOT compute line numbers yourself.",
+              "- The \"code_snippet\" field must contain the actual code from that [LINE N] line.",
+              "",
+              "[PR Context]",
+              "Title: " + pr_title,
+              "Description: " + pr_body,
+              "",
+              "[Project Architecture]",
+              "- Stack: Swift 6, SwiftUI, TCA 1.25, Tuist 4 (multi-module)",
+              "- Layer dependency: Presentation → Domain ← Data, Network is only referenced by Data",
+              "- Deployment target: iOS 26.0 (iPhone only)",
+              "- Source roots: Projects/App, Projects/Presentation, Projects/Domain/{Entity,UseCase,DomainInterface,DataInterface}, Projects/Data/{Model,Repository,API,Service}, Projects/Network/*, Projects/Shared/*",
+              "",
+              "[Review Criteria]",
+              "1. TCA Convention: Verify @Reducer + @ObservableState usage; Action naming describes events that occurred (e.g., xxxButtonTapped, xxxResponse), NOT intended effects (e.g., performLogin, loadData); Effect is .none when no side effect and .run for async work; shared logic lives in private methods, NOT shared Actions; Effect.run must NOT capture entire @ObservableState (extract needed values first); Reducer must NOT perform CPU-intensive work (offload to Effect); Store.scope must use stored property paths only (no computed transforms); Navigation uses @Reducer enum; transient UI state (hover, focus, animation) stays in SwiftUI @State, not TCA State.",
+              "2. Module Architecture: Respect Presentation → Domain ← Data dependency direction; Network is only imported by Data; module boundaries expose protocols (DomainInterface / DataInterface); DTO-to-Entity mapping stays in Data layer.",
+              "3. SwiftUI Convention (이 프로젝트는 AGENTS.md 규칙을 따른다 — SubView 분리는 @ViewBuilder private func 또는 private var 형태가 정식이며 위반이 아니다. SubView 를 struct 로 강제하는 의견은 절대 내지 말 것); use @Binding when a SubView mutates parent @State; no \"View\" suffix in View names (unless clarity requires it); use .frame(maxWidth/maxHeight: .infinity) instead of Spacer() for simple expansion; required props via init, optional props via ViewModifier-style functions.",
+              "4. Swift Code Quality: guard early return with shorthand optional binding (guard let value else { ... }) followed by a blank line; final class by default; private first (avoid fileprivate unless required); never force unwrap; operator line break puts operator at the start of the next line; function params line-break with closing paren on its own line; ternary for simple return/assignment only, split on '?'; [weak self] + guard let self else { return } in closures; constant groups as private enum (Metric/Font/Constant), NOT struct; empty collection literals ([] / [:]); indent 4 spaces; 120-char line limit.",
+              "5. Actionable Feedback: When improvement is needed you MUST provide a concrete Swift fix using GitHub's " + TRIPLE + "suggestion block.",
+              "",
+              "[Severity Prefix]",
+              "Each comment body MUST start with a severity tag on its own line, then a blank line, then the actual comment:",
+              "- 🔴 [P1] Critical: force-unwrap crash risk, retain cycles / memory leaks, heavy or blocking work inside a Reducer, main-thread blocking",
+              "- 🟠 [P2] Major: module dependency-direction violations (e.g., Domain importing Data), Effect.run capturing entire @ObservableState, sharing logic through Actions, Store.scope with computed property, serious concurrency or error-mapping issues",
+              "- 🟡 [P3] Minor: Action naming that describes intent/effect (performLogin, loadData, setRecords), SubView written as @ViewBuilder function, Swift API Design Guideline violations on public APIs, inefficient Effect composition",
+              "- 🔵 [P4] Readability: View-suffix naming, Spacer() misuse, missing final / private, guard / ternary / line-break style violations, constant groups declared as struct instead of enum",
+              "(P5 Nitpick 등급은 사용하지 않는다. 빈 줄·공백·trailing comma·주석 줄 같은 포맷 의견은 절대 만들지 말 것.)",
+              "",
+              "Format: \"🔴 **[P1] Critical**\\n\\nActual comment content here...\"",
+              "",
+              "Ignore the following entirely — these are NOT review issues for this project:",
+              "- blank lines, whitespace, trailing commas, comment-only lines (P5 nitpicks)",
+              "- SubView 를 struct 로 분리하라는 의견 (이 프로젝트는 AGENTS.md 의 @ViewBuilder 패턴이 정식)",
+              "- import 순서, 줄 단위 들여쓰기",
+              "- description 같은 BaseTargetType 의 정식 프로퍼티 네이밍 의견",
+              "",
+              "Only report substantive issues — bugs, architecture violations, security/concurrency risks. Do NOT generate P5 nitpicks. Write all review comments in Korean using Markdown, without greetings or closings.",
+              "",
+              "Respond ONLY with a JSON object in this exact format:",
+              "{",
+              "  \"summary\": \"전체 리뷰 요약 (한국어, 마크다운)\",",
+              "  \"comments\": [",
+              "    {",
+              "      \"path\": \"file path relative to repo root (from the b/ prefix in diff)\",",
+              "      \"line\": <exact N from [LINE N] annotation>,",
+              "      \"code_snippet\": \"the actual code content from that line\",",
+              "      \"body\": \"🔴/🟠/🟡/🔵 **[P1~P4] Label**\\n\\n리뷰 코멘트 (한국어, 마크다운. 개선이 필요하면 " + TRIPLE + "suggestion 블록 포함)\"",
+              "    }",
+              "  ]",
+              "}",
+              "If no issues are found, return {\"summary\": \"...\", \"comments\": []}.",
+              "",
+              "<annotated_diff>",
+              annotated_diff,
+              "</annotated_diff>"
+            ];
+            const prompt = promptLines.join("\n");
             const result = await model.generateContent(prompt);
             const text = result.response.text();
             fs.writeFileSync("review_result.json", text);

AGENTS.md

@@ -474,13 +474,16 @@ public struct HomeCoordinator {
   // … State / Action / handleRoute …
 }
 
+// swiftformat:disable extensionAccessControl
 extension HomeCoordinator {
   @Reducer
   public enum HomeScreen {
     case home(HomeFeature)
     case preVote(PreVoteFeature)
+    case chatRoom(ChatRoomFeature)
   }
 }
+// swiftformat:enable extensionAccessControl
 
 extension HomeCoordinator.HomeScreen.State: Equatable {}
 
@@ -489,15 +492,99 @@ public struct HomeCoordinator {
   @Reducer
   public enum HomeScreen { ... }   // 안 됨 (매크로 인식 / Route 추론 깨짐)
 }
+
+// ❌ 금지 — 자동 포맷터가 `public extension { enum }` 으로 바꾸도록 방치
+public extension HomeCoordinator {
+  @Reducer
+  enum HomeScreen { ... }   // @Reducer 매크로 확장이 internal 로 생성 → "must be declared public" 에러
+}
 ```
 
 규칙:
 - `XScreen` 은 `@Reducer public enum`. struct 로 바꾸지 말 것
 - 본체와 분리된 **별도 extension** 안에 선언
+- **swiftformat 자동 변환 차단**: 해당 블록 앞뒤로 `// swiftformat:disable extensionAccessControl` / `// swiftformat:enable extensionAccessControl` 주석 페어 필수.
+  - 포맷터가 `public extension X { enum XScreen }` 으로 끌어올리면 `@Reducer` 매크로가 만드는 `State` / `Action` / `body` 가 internal 로 생성되어 `enum 'State' must be declared public because it matches a requirement in public protocol 'CaseReducer'` 빌드 에러가 난다.
 - `extension Coordinator.XScreen.State: Equatable {}` 보조 conformance 도 같이 유지 (Route diff 비교 필요)
 - 라우터 핸들러 (`routerAction`) 안에서 `state.routes.push/pop/goBack` 직접 호출은 OK, 단 `dismiss`/`submit` 같이 반복되는 종료 액션은 `.send(.view(.backAction))` 으로 일원화
 - 레퍼런스: `HomeCoordinator`, `AuthCoordinator`, `MainTabCoordinator`
 
+#### 🌐 switch 기반 computed property — 모든 case 에 `return` 명시 유지 (DomainType / BaseTargetType / DependencyKey 공통)
+
+`switch self { ... }` 만으로 값을 돌려주는 computed property 는 **모든 case 에 `return` 키워드를 명시한다**. 적용 범위:
+
+1. **`DomainType.url`** — `PieckeDomain` 같은 도메인 prefix 매핑
+2. **`BaseTargetType` 구현체의 `urlPath` / `method` / `parameters` / `task` / `sampleData`** — 모든 Moya TargetType switch
+3. **`DependencyKey.liveValue` / `testValue`** — `UnifiedDI.resolve(...) ?? Default...()` 패턴
+4. 그 외 단일 표현식 switch 를 본문으로 갖는 computed property 전부
+
+자동 포맷터의 `redundantReturn` 룰이 single-expression switch 에서 `return` 을 떼어내려 하지만, **새 case 추가 시 일부만 implicit / 일부는 explicit 으로 혼합되는 상태가 가장 깨지기 쉽다**. 새 case 추가 후엔 항상 기존 case 까지 같이 `return` 으로 정렬할 것.
+
+```swift
+// ✅ DomainType — 모든 case return
+extension PieckeDomain: DomainType {
+  public var url: String {
+    switch self {
+    case .auth:    return "api/v1/auth/"
+    case .profile: return "api/v1/me/"
+    case .home:    return "api/v1/home"
+    case .poll:    return "api/v1/poll"
+    case .battle:  return "api/v1/battles/"
+    }
+  }
+}
+
+// ✅ BaseTargetType — urlPath / method / parameters 모두 return 명시
+extension BattleService: BaseTargetType {
+  public var urlPath: String {
+    switch self {
+    case let .preVote(battleId, _):
+      return BattleAPI.preVote(battleId: battleId).description
+    case let .scenario(battleId):
+      return BattleAPI.scenario(battleId: battleId).description
+    }
+  }
+
+  public var method: Moya.Method {
+    switch self {
+    case .preVote:  return .post
+    case .scenario: return .get
+    }
+  }
+
+  public var parameters: [String: Any]? {
+    switch self {
+    case let .preVote(_, body): return body.toDictionary
+    case .scenario:             return nil
+    }
+  }
+}
+
+// ✅ DependencyKey — liveValue / testValue 도 return 명시
+public struct BattleRepositoryDependency: DependencyKey {
+  public static var liveValue: BattleInterface {
+    return UnifiedDI.resolve(BattleInterface.self) ?? DefaultBattleRepositoryImpl()
+  }
+  public static var testValue: BattleInterface {
+    return UnifiedDI.resolve(BattleInterface.self) ?? DefaultBattleRepositoryImpl()
+  }
+}
+
+// ❌ 금지 — 포맷터가 떼어낸 implicit return 혼합
+public var method: Moya.Method {
+  switch self {
+  case .preVote:  .post           // ← 안 됨
+  case .scenario: return .get     // ← 혼합 상태
+  }
+}
+```
+
+규칙:
+- 새 case 추가 후 포맷터가 기존 case 의 `return` 을 떼어냈다면 **PR 전에 직접 되돌려서 일관성 유지**
+- 새 도메인 case (`.battle` 등) / 새 서비스 case (`.scenario` 등) / 새 DI 키 추가 시 모두 동일하게 `return ...` 형태로 작성
+- 포맷터가 반복적으로 깨면 해당 파일 또는 함수 블록에 `// swiftformat:disable redundantReturn` 디렉티브 페어 추가 검토
+- 레퍼런스: `PieckeDomain`, `BattleService`, `AuthService`, `BattleRepositoryDependency`, `HomeRepositoryDependency`
+
 ### 📏 Swift 코딩 규칙 (`docs/agent/swift-coding-rules.md`)
 - Swift 스타일 가이드
 - 에러 처리 패턴
@@ -664,6 +751,21 @@ tuist generate --no-open --path Projects/Shared/DesignSystem
 - `@swiftui-uikit-interop` — SwiftUI ↔ UIKit 상호 운용성 전문
 - `@swift-concurrency` — Swift 6 Concurrency 및 async/await 전문
 
+### SwiftUI 전문 가이드 스킬 — `swiftui-expert-skill`
+- **출처**: [AvdLee/SwiftUI-Agent-Skill](https://github.com/AvdLee/SwiftUI-Agent-Skill) (Agent Skills 오픈 포맷)
+- **로컬 설치 위치**
+  - Claude Code: `~/.claude/plugins/SwiftUI-Agent-Skill/`
+  - Codex: `~/.codex/skills/swiftui-expert-skill/`
+  - Cursor 도 동일 폴더를 `Plugins` 가이드대로 등록하면 됨
+- **재설치 / 업데이트**
+  ```bash
+  rm -rf ~/.claude/plugins/SwiftUI-Agent-Skill ~/.codex/skills/swiftui-expert-skill
+  git clone https://github.com/AvdLee/SwiftUI-Agent-Skill.git ~/.claude/plugins/SwiftUI-Agent-Skill
+  cp -R ~/.claude/plugins/SwiftUI-Agent-Skill/swiftui-expert-skill ~/.codex/skills/swiftui-expert-skill
+  ```
+- **언제 호출**: SwiftUI 상태관리(`@Observable` / 프로퍼티 래퍼 선택), 뷰 컴포지션, 리스트·내비게이션·시트, Swift Charts, 애니메이션, macOS multi-window, iOS 26+ Liquid Glass, 접근성, Instruments 트레이스 분석.
+- **호출 방법**: 프롬프트에 *"swiftui-expert skill 을 사용해 ..."* 형태로 지시하거나, `.trace` 경로/녹화 요청처럼 트리거 키워드가 들어오면 자동 활성화.
+
 ### 자동 호출 키워드
 다음 키워드 언급 시 **자동으로 성능 최적화 스킬 호출**:
 - `ifCaseLet`, `TCA`, `Effect`, `메모리 누수`, `성능`, `최적화`