add setting to toggle joining vc on room click

[RasmusAntons]

Description

I added one setting that lets the user disable the behavior of immediately joining a voice call when clicking the NavButton. I personally am stupid and will accidentally join a voice sometimes call which is very embarrassing.

I'm not sure if the settings hierarchy is what you have in mind, if not feel free to make changes or close this PR and implement something like this yourselves.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[hazre]

What if it required double clicking the room to join it instead, would that solve your problem? Double clicking within a period joins room, otherwise it shows the prescreening view.

[RasmusAntons]

That would solve the issue, but I don't know if that would feel intuitive. As far as I know that would be the only double click action anywhere in Sable? Clicking the "Join" button once to join feels pretty reasonable to me.

[7w1]

Hey, if you'd still like to add this could you update your fork to dev, move the setting into the new Call section in general, and add a changeset?

[dozro]

Will mark it as a draft, as there hasn't been activity in the last week, and it has open merge conflicts.

Feel free to mark it as ready once these are fixed :3

[nushea]

Superseded by #768 because the pr has been inactive for 2 months