Repository navigation
Keep the selected drive by its whole path - #1067
Merged
Merged
Conversation
Scanning for discs and leaving the parameter editing looked for the selected drive by the first character of its device path, which was the drive letter before drives used paths. On Linux every device path starts with "/" and on macOS every BSD name with "d", so the selection moved to another drive, such as /dev/sg0 instead of /dev/sr0. Both now look for the whole path first. Windows paths already differ in their first character, and leaving the parameter editing still falls back to the drive letter, which Aaru and Redumper are given without the rest of the path, while DiscImageCreator and Dreamdump get the whole path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-drive Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mnadareski
approved these changes
Oct 26, 2026
mnadareski
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux and macOS, the selected drive changes to another drive after "Scan for Discs", and after editing the parameters when the box next to them is ticked again. Both looked for the selected drive by the first character of its device path, which was the drive letter before drives used paths (d68175d). Every device path on Linux starts with
/and every BSD name on macOS withd, so another drive starting with the same character was selected.Both now look for the whole path first. Editing the parameters still falls back to the drive letter: on Windows, MPF gives DiscImageCreator and Dreamdump the whole path (
E:\), but Aaru and Redumper only the letter (E:andE).Measured on master (18cc680) and this branch by running
MainViewModelas the window does, with the real drives and, for each run, a new configuration that only sets the paths of the dumping programs:Init, then for each drive with a disc, select it and run what "Scan for Discs" runs, and select it and process the parameters generated for Aaru, DiscImageCreator, Dreamdump and Redumper as ticking the box does./dev/sg0and/dev/sr0): with/dev/sr0selected, master selects/dev/sg0after both, with all four programs. This branch keeps/dev/sr0.disk1and a USB drive asdisk8): withdisk8selected, master selectsdisk1after both, with all four programs. This branch keepsdisk8./dev/sr2stays selected after "Scan for Discs".D:\andE:\): master and this branch keep either drive selected after both. Without the fallback to the drive letter, editing the parameters selectsD:\instead ofE:\with Aaru and Redumper.Prepared with AI assistance (Claude Opus 5.5) and reviewed before submission.