Add stagger delay to fix frontdoor login#7
Open
kckrithika wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Here's the PR to fix Issue 6. Could you please check if this fix works for you? Please check out to frontdoor-access-fix branch and follow the same instructions in README to run the test login. |
|
@kckrithika |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved a race condition in the frontdoor login flow by implementing a locking mechanism to ensure the singleaccess endpoint is accessed sequentially rather than in parallel.
The Problem
The singleaccess endpoint generates a one-time-use frontdoor URL that is invalidated the moment the endpoint receives a new request.
Bug
Multiple "frontdoor login" attempts were hitting the endpoint parallelly. A race condition occurred where a second request would invalidate the URL generated by the first before the authentication flow could complete, leading to intermittent login failures.
The Fix
The test script now calls the endpoint sequentially. The main scripts now have a Lock to synchronize access to the singleaccess endpoint. The lock ensures that only one request can hit the endpoint at a time.