feat(api): expose fiscal configuration - #146
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The endpoint behavior matches the stated contract (auth, isolation, projection, no-store, Decimal string rates) and is backed by targeted tests covering the key acceptance criteria.
Pull request overview
This PR adds a read-only API endpoint to expose the current fiscal configuration for the caller’s active workspace, aligning with the existing active-workspace session model and enforcing tenant isolation and role-based access via the fiscal service layer.
Changes:
- Introduces a distinct domain outcome for “authorized workspace but no fiscal configuration” (
FiscalConfigurationNotConfigured). - Adds
GET /api/v1/fiscal-configuration/with strict field projection, query-param rejection, andCache-Control: no-store. - Adds API tests covering auth/session requirements, tenant isolation, role enforcement, 404 contract, Decimal-as-string serialization, and 405 JSON responses.
File summaries
| File | Description |
|---|---|
| backend/fiscal/services.py | Splits “missing configuration” into an explicit not-configured outcome separate from access denial. |
| backend/api/fiscal_views.py | Implements the read-only fiscal configuration endpoint with strict projection and error mapping. |
| backend/api/urls.py | Registers the new fiscal configuration route under the API v1 namespace. |
| backend/api/tests.py | Adds endpoint-focused tests for access control, isolation, serialization, and HTTP contract behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/fiscal-configuration/for the active workspace's current fiscal configuration.Changes
backend/fiscal/services.pybackend/api/fiscal_views.pybackend/api/urls.pybackend/api/tests.pyTesting
python manage.py checkpython manage.py makemigrations --check --dry-rungit diff --checkContributor checklist
type:*labelCo-Authored-BytrailersCloses #145