feat: add support for webapp-runner flavor - #78
Conversation
There are now two "flavors" of webapp-runner: - a "default" one, which is the one we support since ever ; - a "main" one, which doesn't include Memcached and Redis client libraries. The "main" flavor is sometimes useful, because some libraries can sometimes conflict with similar ones used in the app. This commit also introduces the use of two INVENTORY-*.tsv files (one for each flavor).
- Removes tests for JVM 18 and 19 - Adds tests for JVM 21 (LTS) and 25 (LTS) - Updates a few test::utils functions for better output - Updates default versions of webapp-runner
![semgrep-code-scalingo[bot]](https://avatars.githubusercontent.com/u/4868969?s=60&v=4){kind=small}
EtienneM
left a comment
EtienneM
left a comment
There was a problem hiding this comment.
That's really nice to see the cmnlib being used. We can see how easy it is to read code written using it 🙌
| name: "ShellCheck" | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: Scalingo/actions/shellcheck@8c4d8c7b3d03b58f44873ba2e281f1c2de2a3381 |
There was a problem hiding this comment.
we tend to prefer sticking to main for actions repository so that we benefit from new versions instantly
| - uses: Scalingo/actions/shellcheck@8c4d8c7b3d03b58f44873ba2e281f1c2de2a3381 | |
| - uses: Scalingo/actions/shellcheck@main |
There was a problem hiding this comment.
While I agree with you, I have the displeasure to let you know that merging is blocked by Semgrep if I don't put a precise SHA checksum here -_-
There was a problem hiding this comment.
question: I hate Makefile. Do we want to keep using one?
There was a problem hiding this comment.
Well, I have the same feeling towards Makefiles.
But it's been asked by @leo-scalingo.
I personnaly don't see any blocker to remove it.
There was a problem hiding this comment.
If the teasks in the makefile are still working I would keep it since it's really simple, otherwise remove it. I don't remember asking haha
|
|
||
| set -eo pipefail | ||
| cmnlib="$( readlink -f "$( dirname "${0}" )/../vendor/cmnlib.sh" )" | ||
| # shellcheck source=vendor/cmnlib.sh |
There was a problem hiding this comment.
praise: oh nice, I didn't know that 🙌
3 participants
webapp-runner-main) that, unlike the "usual" one, doesn't provide client libraries for Memcached or Redis. To use this new flavor, setJAVA_WEBAPP_RUNNER_FLAVORtomain.Successfully tested here: https://fku-war.osc-st-fr1.apps.st-sc.fr