feat(github-workflow): add missing issues activity types - #6212
Open
MattSkala wants to merge 1 commit into
Open
Conversation
GitHub supports typed, untyped, field_added and field_removed for the issues event, but the schema stops at demilestoned. Add the four values to the enum and to the identical default list, and cover them with a positive test. Closes SchemaStore#6211
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6211
What
Adds the four
issuesactivity types that GitHub supports but the schema does not accept:typed,untyped,field_added,field_removedref: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#issues
typedanduntypedcame with Issue Types. They are the only way to start a workflow when a user sets or removes the type of an issue, so a triage workflow that acts on one type cannot see an issue that gets its type after creation.The value list appears twice in the
issuesblock, so this changes both theenumand the identicaldefault.Test
Adds
src/test/github-workflow/issues-activity-types.yaml, which lists every documented activity type for the event.I checked that the test fails without the schema change (5 Ajv errors) and passes with it:
Prettier reports no changes for either file.