Skip to content

UK study variant - #216

Open
lukaskollmer wants to merge 10 commits into
feature/track-grove-0.3.0-beta.8from
lukas/uk-study-variant-fixes
Open

lukaskollmer wants to merge 10 commits into
feature/track-grove-0.3.0-beta.8from
lukas/uk-study-variant-fixes

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

♻️ Current situation & Problem

MHC currently makes the implicit assumption that there is only a single "variant" of the study (the Stanford one) and, in some places, uses the device region to differentiate between Stanford and Imperial stuff.

this isn't good enough, as it would be absolutely feasible for someone in the US (who would end up enrolling in the Stanford variant) to have their phone's language set to en-GB, or their phone's region set to the UK.

SchmiedmayerLab/MyHeartCounts-StudyDefinitions#50 introduces the notion of a Study Variant (see SchmiedmayerLab/MyHeartCounts-StudyDefinitions#49 for more info); this PR updates MHC to support that as well.

⚙️ Release Notes

  • added support for study variants, allowing the app to fetch a specific variant's study bundle, based e.g. on user data entry during the initial onbording screening page

📚 Documentation

no

✅ Testing

yes (for consent loading, which arguably is the most important thing we need to be study-variant-dependent)

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2760a946-f2e6-4c92-a255-5da29a0cf75c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukaskollmer
lukaskollmer force-pushed the lukas/uk-study-variant-fixes branch from 749b060 to 7fcf19a Compare September 26, 2026 11:16
@lukaskollmer lukaskollmer changed the title Fix consent selection for UK study testing UK study variant Sep 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant