Review ebourne cleanup cmake#234
Merged
EmilyBourne merged 3 commits intoSciCompMod:ebourne_cleanup_cmakefrom Apr 30, 2026
Merged
Review ebourne cleanup cmake#234EmilyBourne merged 3 commits intoSciCompMod:ebourne_cleanup_cmakefrom
EmilyBourne merged 3 commits intoSciCompMod:ebourne_cleanup_cmakefrom
Conversation
EmilyBourne
approved these changes
Apr 30, 2026
6971888
into
SciCompMod:ebourne_cleanup_cmake
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review in #214 is a bit difficult to follow, so I decided to open a dedicated PR on the branch of @EmilyBourne.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):