Skip to content

qa: remove broad ambiguity and import exemptions - #85

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa-remove-broad-suppressions
Aug 26, 2026
Merged

qa: remove broad ambiguity and import exemptions#85
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa-remove-broad-suppressions

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Aug 26, 2026

Copy link
Copy Markdown
Member

Removes the broad Aqua ambiguity and ExplicitImports no-implicit-imports exemptions tracked in #71. Imports are now explicit, the QR in-place solve dispatch is narrowed to the dense and ArrayLayouts RHS families implemented here, and the two LazyArrays __arguments intersections are disambiguated.

Adds direct vector and matrix ldiv! coverage for the retained QR solve paths.

Please ignore until reviewed by @ChrisRackauckas.

Verification

  • GROUP=QA julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
    • QA/qa.jl | 20 / 20 passed
    • QA/alloc_tests.jl | 11 / 11 passed
  • GROUP=Core julia --startup-file=no --project=. -e 'using Pkg; Pkg.test()'
    • Core/core_tests.jl | 83 passed, 2 existing broken, 85 total
  • Runic.format_file(...; inplace=true), typos src/FastAlmostBandedMatrices.jl test/core_tests.jl test/qa/qa.jl, and git diff --check

No documentation build was run because this PR changes no public documentation or docstrings.

🤖 Generated with Claude Code
https://chatgpt.com/codex/tasks/019f4028-d2ae-7a12-aff0-7d996bd9c791

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

Co-Authored-By: Claude <noreply@anthropic.com>

Claude-Session: https://chatgpt.com/codex/tasks/019f4028-d2ae-7a12-aff0-7d996bd9c791
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review August 26, 2026 07:12
@ChrisRackauckas
ChrisRackauckas merged commit 1b08daf into SciML:main Aug 26, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants