Repository navigation
Use Iterators.flatten for nested level_iter - #164
Merged
ChrisRackauckas merged 2 commits intoAug 28, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
import …: recursivecopy does not bind the package name, so RecursiveArrayTools.chain in level_iterations.jl fails under both main and Downgrade CI. Co-authored-by: Cursor <cursoragent@cursor.com>
RecursiveArrayTools.chain is not public, so binding the module and calling RecursiveArrayTools.chain fails ExplicitImports all_qualified_accesses_are_public. Base.Iterators.flatten is the public equivalent and keeps Core level iteration working. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Grok Build TUI <noreply@x.ai> Agent-Harness: Grok Build TUI 1.0.5 (5115b46bc9) Agent-Model: grok-4.6 Agent-Session: 01a047d2-fbfd-7b31-acb4-8487afb35ac6 (local transcript /home/crackauc/.grok/sessions/%2Fhome%2Fcrackauc%2Fsandbox%2Ftmp_20260828_100319_18686/01a047d2-fbfd-7b31-acb4-8487afb35ac6/)
ChrisRackauckas-Claude
marked this pull request as draft
August 28, 2026 11:04
ChrisRackauckas-Claude
changed the title
ChrisRackauckas
marked this pull request as ready for review
August 28, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
level_iterforn > 1concatenated child iterators viaRecursiveArrayTools.chain. That name is not public in RecursiveArrayTools.import RecursiveArrayTools) makes Core work, but QAall_qualified_accesses_are_publicthen fails: ``chainis not public in RecursiveArrayTools.Base.Iterators.flatteninstead, so Core and QA both pass without depending on RecursiveArrayTools internals.Ignore until reviewed by @ChrisRackauckas.
Test plan
Fail-before / pass-after (Julia 1.12.4):
8733161):collect(level_iter(tis, 2))raisesUndefVarError: RecursiveArrayTools not defined.5631cb3, module bind only):GROUP=QAerrors onall_qualified_accesses_are_public(chainis not public). Exit 1. 19 passed, 1 errored.GROUP=QA20/20 passed.GROUP=Corepassed, includingCore/level_iter_tests.jl9/9 andCore/indexing_and_creation_tests.jl134/134.Local commands:
Not verified: GPU, Downgrade CI on this commit (Downgrade was already green on the previous commit), Julia pre.
🤖 Generated with Grok Build TUI 1.0.5 (model: grok-4.6)
Session: 01a047d2-fbfd-7b31-acb4-8487afb35ac6 (local transcript)