Repository navigation
Fix take_first_char MethodError on 32-bit Julia - #168
Merged
ChrisRackauckas merged 1 commit intoSep 9, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
n_char_per_name is Int (Int32 on i686); the Int64-only method never matched. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
CI is green and this PR is merge-ready ( |
Member
Author
|
x86 Core is green on this PR. Merge when convenient — unblocks SciML 32-bit CI parity (no architecture-specific hard fails). |
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 10, 2026
- Add 32-bit Core CI lane via test_groups.toml (#166) - Accept Integer in take_first_char for 32-bit Julia. (#168) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
take_first_char(..., N::Int64)to::Integerso it matchesInton 32-bit hostsMethodError: take_first_char(::SubString{String}, ::Int32)Test plan
Made with Cursor