fix(cli-wallet): use canonical RTC hex addresses#6519
Merged
Conversation
This was referenced May 28, 2026
Contributor
Author
|
CI follow-up: the initial run failed during Python test collection before reaching this wallet change because I added a second tiny commit that restores the intended indentation for the GPU release settlement block. Local verification for that unblocker: Cargo is still unavailable on this Windows host, so the |
Contributor
Author
|
Follow-up on the second CI run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6518.
This updates the legacy
tools/cli-walletaddress path so it no longer emits or accepts Base58-styleRTC...addresses. It now aligns with the canonical RustChain format used by the current wallet/docs:RTCplus 40 hexadecimal characters.Changes
RTC+ first 40 hex chars of SHA-256 over the wallet public key bytes.RTC[0-9a-fA-F]{40}semantics.base58dependency from the legacy CLI wallet crate.Verification
Local Windows host does not currently have Cargo installed, so I could not run the Rust crate tests locally.
Static checks performed:
The first check passed. The second check returns no remaining Base58 usage in
tools/cli-wallet.