feat(experiments): add configurable baseline variants#14
Open
lordspline wants to merge 3 commits into
Open
Conversation
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| raise ValidationError(f"cannot exclude holdout pseudo-variants: {sorted(holdout_excluded)}") | ||
| holdout_excluded = {k for k in excluded_variants if k.startswith("holdout-")} | ||
| if holdout_excluded: | ||
| raise ValidationError(f"cannot exclude holdout pseudo-variants: {sorted(holdout_excluded)}") |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configurable baseline variant selection to PostHog experiments. Users can now choose any variant as the baseline for statistical analysis via
stats_config.baseline_variant_key, instead of being forced to use a hardcodedcontrolvariant. Legacy experiments default tocontrolor the first configured variant for backward compatibility. Variant keys are never renamed—baseline selection is analysis-only metadata that does not mutate feature flags or historical exposure.resolve_baseline_variant_keyvalidates against flag variants, handles missing/removed baselines, and updates query runners (trends/funnels/metrics) to use the selected baselinebaseline_variant_keyparameterNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.