fix(insights): show previous-period date in tooltips#21
Open
lordspline wants to merge 2 commits into
Open
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users comparing insights to a previous period previously only saw generic labels like "Previous" and "Current" in tooltips. Without the actual date, they had to do mental math to understand which time period the comparison referred to.
Changes
date_labelwith formatted dates from the dataset'sdaysarrayformatCompareLabelWithDateas the default formatter whenformatCompareLabelis undefinedHow did you test this code?
createTooltipDatawith different intervals and timezonesformatCompareLabelWithDateAutonomy: Fully autonomous
Implemented actual previous-period date labels in insight tooltips. Traced tooltip data path from
LineGraph.tsxthroughcreateTooltipDataintooltip-data.ts, added formatting options for interval/dateRange/timezone/weekStartDay to generate real dates viagetFormattedDate, updatedformatCompareLabelWithDateto append the formatted date to the compare label, and added regression tests for day/week/month/timezone cases.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.