fix(sql-editor): debounce decoration updates while typing#23
Open
xPolar wants to merge 1 commit into
Open
Conversation
… on large queries Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Editing large SQL queries stalls the editor because every input update resolves the active subquery immediately. That path parses the full query with the HogQL WASM parser before the browser can paint.
Fixes PostHog#60974.
Changes
How did you test this code?
sqlEditorLogic.test.ts.Automatic notifications
Docs update
No documentation changes are needed for this editor performance fix.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Captain Capy reproduced and profiled the issue with a Playwright/Chrome DevTools benchmark. The chosen fix defers existing decoration work rather than caching parser output globally, keeping behavior scoped to each editor logic while eliminating per-keystroke parsing.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.