fix(cdp): distinguish destination invocation statuses#25
Open
0xluffyb wants to merge 1 commit into
Open
Conversation
…for colorblind usability Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CDP destination invocation results need to remain unambiguous without relying on red and green. The existing status tags had text but no iconographic cue or explicit accessible name.
Changes
Status: …accessible labelsHow did you test this code?
I am an agent. I ran the focused Jest test, oxlint on all changed files, the frontend TypeScript check, and a Storybook browser check that asserted the visible icons and accessible labels. I also captured the destination logs in the normal palette and under a deuteranopia simulation.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs update is needed because this changes the presentation and accessibility of existing statuses without changing product behavior.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Capy. A shared component was chosen so logs and testing cannot drift in status semantics; icons are decorative to assistive technology while the tag carries the explicit accessible name. Verification used the existing multi-result destination Storybook fixture.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.