fix(data-warehouse): improve SQL editor typing latency#8
Open
lordspline wants to merge 1 commit into
Open
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Large SQL editor documents could make typing feel frozen because active-query decorations synchronously re-parsed the current SQL document after every content change. This addresses PostHog#60974.
Changes
How did you test this code?
SQL_EDITOR_LATENCY_BENCHMARK=1 hogli test frontend/src/scenes/data-warehouse/editor/sqlEditorLatency.benchmark.test.tshogli test frontend/src/scenes/data-warehouse/editor/sqlEditorLogic.test.ts frontend/src/scenes/data-warehouse/editor/multiQueryUtils.test.tspnpm --filter=@posthog/frontend formatpnpm --filter=@posthog/frontend typescript:checkAutomatic notifications
Docs update
No docs update needed; this is a SQL editor interaction-performance fix.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Capy reproduced the issue with a deterministic large SQL document and profiled before changing code. The dominant hot path was HogQL parser/WASM work from active-query decoration refreshes, so the fix moves only that visual decoration work off the keypress-ready path instead of debouncing the editor state itself.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.