Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When manually assigning properties to categories, it often happens that one proof refers to an assignment made earlier in the file. However, before this PR, manually assigned properties were listed alphabetically. This could be confusing, since the proofs could not be read from top to bottom in their natural order. It could also result in less important properties being listed first.
This PR resolves the issue by assigning an autoincrementing ID to every property assignment, whether manual or deduced. Previously, the table used a composite primary key consisting of category ID and property ID. Displayed properties are now ordered by ID and therefore appear in the same order as in the file where they are assigned. This also allows contributors to deliberately choose which properties should be shown first.
The
positioncolumn previously used for deduced properties is now redundant. Deduced properties are still displayed in a logical order, unaffected by this PR, and their order cannot be influenced by contributors.The same remarks apply to assignments of properties to functors.
Before
This is from the
walking_forkpage. It is weird that "cofiltered-limit-stable epimorphisms" appears first.After
This has now the same order as in the file:
Before
This is taken from the
Toppage. It is weird that "locally small" is quite at the bottom, while "coregular" is quite at the top (among other things).After