test: assert observable CLI behavior - #66
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 829a6f501b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -19,13 +19,3 @@ test("npm package metadata identifies the public source repository", () => { | |||
| url: "https://github.com/ScriptedAlchemy/grok-bot-cli/issues", | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
Keep coverage for the grok-bot executable alias
Deleting this test leaves the published grok-bot command unverified: the packed-package smoke test in .github/workflows/ci.yml invokes only gbot and gbot-install, while package.json still exposes the long-standing grok-bot alias. If that alias is removed or misspelled, CI will remain green but existing users invoking grok-bot will lose their executable; retain a focused alias assertion or execute it in the packed-package smoke test.
Useful? React with 👍 / 👎.
Replace tests that pin implementation constants with an assertion on the CLI's observable error fallback. Keep executable coverage in the packed installation smoke test, including both
gbotand itsgrok-botalias, plusgbot-install.Validation: full local check passed (201 unit tests and 13 route tests), actionlint passed, and a real packed installation ran all three executable help commands. The final contribution added only whitespace cleanup; the affected suites passed again (11 tests). Hosted checks remain queued without starting.