Skip to content

test: assert observable CLI behavior - #66

Merged
ScriptedAlchemy merged 4 commits into
mainfrom
test-behavior-audit-50-51
Sep 16, 2026
Merged

ScriptedAlchemy merged 4 commits into
mainfrom
test-behavior-audit-50-51

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Replace tests that pin implementation constants with an assertion on the CLI's observable error fallback. Keep executable coverage in the packed installation smoke test, including both gbot and its grok-bot alias, plus gbot-install.

Validation: full local check passed (201 unit tests and 13 route tests), actionlint passed, and a real packed installation ran all three executable help commands. The final contribution added only whitespace cleanup; the affected suites passed again (11 tests). Hosted checks remain queued without starting.

@changeset-bot

changeset-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 717dce5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T06:04:28.031323Z 829a6f5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 829a6f501b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -19,13 +19,3 @@ test("npm package metadata identifies the public source repository", () => {
url: "https://github.com/ScriptedAlchemy/grok-bot-cli/issues",
});
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep coverage for the grok-bot executable alias

Deleting this test leaves the published grok-bot command unverified: the packed-package smoke test in .github/workflows/ci.yml invokes only gbot and gbot-install, while package.json still exposes the long-standing grok-bot alias. If that alias is removed or misspelled, CI will remain green but existing users invoking grok-bot will lose their executable; retain a focused alias assertion or execute it in the packed-package smoke test.

Useful? React with 👍 / 👎.

@ScriptedAlchemy
ScriptedAlchemy merged commit 8657cb4 into main Sep 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant