fix(install): preserve Codex settings during replacement - #93
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 12eb32f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Replacing a Codex installation through the generated installer used remove followed by add, which deletes nested plugin MCP overrides. Pin the verified Agent Bundle main commit ab5ae66 so replacement uses native add only and preserves those settings.
Scope
Update the compiler/runtime preview pair and native lockfile. Add a patch changeset for the generated installer correction. Preserve the pending shared-skill-library minor changeset.
Tradeoffs
Replacement refuses disabled or unknown plugin-level enablement before mutating Codex, since native add would reset that flag. Users can enable the plugin in Codex before replacing it.
Blast radius
The build inputs and generated installer change. Application source and public package versions remain unchanged; native Changesets controls the eventual release version.
Verification
npm ciand fullnpm run checkpassed: 405 unit tests and 15 route tests.enabled = falseoverride and unrelated configuration, and refreshed owned content.enabledomitted both failed with only an inventory read. Configuration and installed content remained unchanged.git diff --checkpassed.