deps: pin vitest's transitive vite to 8.0.16 (react & vue)#267
Merged
Conversation
The direct vite devDependency is already 8.0.16, but vitest@4.1.9 pulls its own vite (8.0.8/8.0.9, range ^6||^7||^8), which is in the vulnerable range for GHSA-fx2h-pf6j-xcff (high) and GHSA-v6wh-96g9-6wx3 (medium). Add a `resolutions` entry forcing vitest/vite to 8.0.16 so only the patched version resolves — same approach already used in the angular samples. Dev/build-time only; not shipped in built apps. Verified: build and vitest pass for all four samples. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses Dependabot security alerts in the React and Vue samples by ensuring Vitest’s transitive vite dependency is resolved to the already-approved, non-vulnerable vite@8.0.16 (matching the direct devDependency), aligning these samples with the existing approach used in the Angular samples.
Changes:
- Add Yarn
resolutionsto forcevitest/vite→8.0.16in the React and Vue samplepackage.jsonfiles. - Update the corresponding
yarn.lockfiles so onlyvite@8.0.16is resolved (removing priorvite@8.0.8/8.0.9resolutions).
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| samples/vue/token-refresh/package.json | Adds resolutions.vitest/vite pin to 8.0.16. |
| samples/vue/token-refresh/yarn.lock | Updates lockfile to remove older resolved Vite versions and reflect vite@8.0.16. |
| samples/vue/login-pkce/package.json | Adds resolutions.vitest/vite pin to 8.0.16. |
| samples/vue/login-pkce/yarn.lock | Updates lockfile to remove older resolved Vite versions and reflect vite@8.0.16. |
| samples/react/token-refresh/package.json | Adds resolutions.vitest/vite pin to 8.0.16. |
| samples/react/token-refresh/yarn.lock | Updates lockfile to remove older resolved Vite versions and reflect vite@8.0.16. |
| samples/react/login-pkce/package.json | Adds resolutions.vitest/vite pin to 8.0.16. |
| samples/react/login-pkce/yarn.lock | Updates lockfile to remove older resolved Vite versions and reflect vite@8.0.16. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bwereszczak
approved these changes
Jun 18, 2026
ikawalec
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the remaining
viteDependabot alerts (#63–#72) in the react and vue samples.Root cause
The direct
vitedevDependency is already8.0.16, butvitest@4.1.9pulls its ownvite(resolved to 8.0.8/8.0.9 via^6 || ^7 || ^8), which falls in the vulnerable range:Fix
Add a
resolutionsentry forcingvitest/vite→8.0.16in all four samples (react & vue × login-pkce + token-refresh) — the same approach already used in the angular samples. After this, onlyvite@8.0.16resolves in each lockfile.Dev/build-time only —
vite/vitestare not shipped in the built apps.🤖 Generated with Claude Code