Fix fresh-checkout builds - #1
Open
onionviolet wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fresh checkouts could not reliably build the native library or config app without
manually preparing dependencies and package paths.
This change:
scripts/build.sh;toolchain.
It does not change injection, hook, or feature behavior.
Testing
Run from a clean detached worktree based on current upstream
main:swift package resolve --package-path macsteam-apppassed and resolved Sparkle 2.9.6.make testpassed by taking the repository's existing clean-checkout no-local-tests path.make -j2passed and produced an ad-hoc-signed universalout/macsteam.dylib.bash macsteam-app/make_app.shpassed and produced an ad-hoc-signed arm64 app bundle.build/.dobby-revisioncaused Dobby to rebuild and the arm64library to relink.
git diff --check upstream/main...HEADpassed.Known upstream warnings remain: Dobby's CMake deprecation/assert warnings and the
existing dynamic
Selectorwarning inAppDelegate.swift.AI assistance
I am the sole human contributor to this pull request. AI assisted substantially through
OpenAI Codex, including GPT-5.6 Sol for an independent final-diff and test review. The
review found two build-cache and empty-test-target problems, which were fixed before this
PR was opened. The clean-build commands and results above were then rerun. I have not
added any AI identity as a commit author or co-author.
This PR addresses fresh checkouts failing before the project and config app can build.
I'm happy to adapt the implementation or have portions rewritten to better fit the
project.