Repository navigation
Refactor(dates): Remove the schema subpath - #382
Merged
Merged
Conversation
@semantic-ui/dates is a Temporal wrapper and carries no schema integration. The `./schema` subpath, its optional peer, its types and its docs page are removed.
⚪ Bundle size: no meaningful change · -153 shipped LOC for
|
| signal | result |
|---|---|
component brotli |
0 B |
| Shipped LOC | -153 |
| Comment LOC | -28 |
| Changed bundles | 0 / 25 |
No bundle changed size. 🎉
LOC by scope: -153 shipped LOC · -28 comment LOC
Shipped LOC excludes comments and blank lines.
| scope | shipped LOC | comment LOC |
|---|---|---|
dates |
-153 | -28 |
All 25 bundles, gzip, and raw sizes
| bundle | group | brotli | Δ brotli | gzip | Δ gzip | raw | Δ raw |
|---|---|---|---|---|---|---|---|
compiler |
package | 6.2 KB | — | 6.9 KB | — | 18.7 KB | — |
component 🎯 |
package | 48.2 KB | — | 54.7 KB | — | 167.5 KB | — |
dates |
package | 11.2 KB | — | 12.3 KB | — | 40.7 KB | — |
query |
package | 16.3 KB | — | 18.2 KB | — | 53.3 KB | — |
reactivity |
package | 7.9 KB | — | 8.8 KB | — | 26.8 KB | — |
renderer |
package | 45.4 KB | — | 51.6 KB | — | 159.7 KB | — |
specs |
package | 54.0 KB | — | 63.9 KB | — | 236.6 KB | — |
tailwind |
package | 70.1 KB | — | 88.2 KB | — | 346.5 KB | — |
templating |
package | 29.9 KB | — | 33.5 KB | — | 99.8 KB | — |
utils † |
package | 25.2 KB | — | 28.2 KB | — | 73.1 KB | — |
framework |
framework | 122.4 KB | — | 155.1 KB | — | 640.4 KB | — |
button |
primitive | 12.1 KB | — | 15.3 KB | — | 129.0 KB | — |
card |
primitive | 3.0 KB | — | 3.5 KB | — | 15.8 KB | — |
container |
primitive | 694 B | — | 888 B | — | 2.4 KB | — |
divider |
primitive | 1.6 KB | — | 1.9 KB | — | 6.5 KB | — |
icon |
primitive | 19.2 KB | — | 24.0 KB | — | 84.4 KB | — |
image |
primitive | 776 B | — | 993 B | — | 2.2 KB | — |
input |
primitive | 4.0 KB | — | 4.6 KB | — | 15.8 KB | — |
label |
primitive | 1.3 KB | — | 1.6 KB | — | 5.5 KB | — |
menu |
primitive | 14.1 KB | — | 16.2 KB | — | 64.2 KB | — |
modal |
primitive | 1.7 KB | — | 2.0 KB | — | 6.7 KB | — |
rail |
primitive | 534 B | — | 695 B | — | 1.5 KB | — |
segment |
primitive | 3.1 KB | — | 3.7 KB | — | 19.7 KB | — |
spinner |
primitive | 1.8 KB | — | 2.1 KB | — | 8.0 KB | — |
table |
primitive | 555 B | — | 692 B | — | 1.3 KB | — |
brotli q11 · gzip l9 · vs main · fresh build both sides · 1m04s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
This removes schema definitions from
@semantic-ui/dates. They will now live in a deep path@semantic-ui/schema/datesand the date library will remain aday.jsstyle Temporal wrapper for general use.On net this simplifies the dep graph for dates, and the re-export pair from the two created more hassle than it solved.
This also cleans up the docs to no longer reference the schema exports so Dates remains a pure Temporal wrapper at its heart.