Skip to content

[AMD][MI35X] 0925 DSV4 sglang mtp agentic - #3430

Open
1am9trash wants to merge 2 commits into
mainfrom
amd/dsv4-mi355x-agentic-fp8kv-megamoe
Open

1am9trash wants to merge 2 commits into
mainfrom
amd/dsv4-mi355x-agentic-fp8kv-megamoe

Conversation

@1am9trash

Copy link
Copy Markdown
Collaborator

Summary:

  • Update image to lmsysorg/sglang-rocm:v0.5.20-rocm720-mi35x-20260925.
  • Switch attention to fp8 unified KV; enable grouped decode on TP8-only arms at conc >= 16.
  • Enable breakable CUDA-graph prefill (BCG) at conc <= 4.
  • Enable EP8 + MegaMoE for DP-attention arms at conc >= 128 (including conc 384).

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps only run on labeled PRs. Add full-sweep-fail-fast (strongly recommended); use full-sweep-enabled only when matrix jobs should continue after a failure.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**扫描仅在带有标签的 PR 上运行。强烈建议添加 full-sweep-fail-fast;仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@1am9trash 1am9trash added AMD agentx AgentX benchmarks, recipes, and infrastructure full-sweep-enabled labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. Because it introduces a new EP8+MegaMoE/EPLB code path, several new decode/prefill tuning flags (unified KV fp8, grouped-decode ASM, breakable CUDA-graph prefill), and shifts the DP-attention search-space arm from EP1 to EP8 with a new 384-concurrency point, a human (ideally one of the CODEOWNERS already on configs/amd-master.yaml) should still confirm the perf numbers before merge.

What was reviewed:

  • New BCG_ARGS/EP_SIZE-branch env vars in the script — these are recipe-local tuning constants derived from already-validated CONC/EP_SIZE, not unvalidated caller config.
  • perf-changelog.yaml entry — correctly appended at the tail; its pull/XXX placeholder matches an existing untouched entry elsewhere in the file, so it's not a new deviation.
  • Image bump scope — recipe is multinode: false, so the multi-node model.container == image cross-check doesn't apply.
  • New EP8 path writes expert-distribution stat files to shared /tmp rather than $RESULT_DIR (line 162) — a plausible minor collision risk on a reused AMD runner, but low severity since it's only diagnostic EPLB stat output, not benchmark results.
Extended reasoning...

The diff is confined to one AMD MI355X SGLang recipe: an image bump, a DP-attention search-space change (ep:1→ep:8, +conc 384), and a script restructure that adds a new EP8+MegaMoE/EPLB code path alongside fp8 unified KV, grouped decode, and breakable CUDA-graph prefill flags. No injection/auth/secrets surface is touched; the risk here is purely performance/behavioral correctness of a GPU serving recipe. The change is larger and more consequential than a mechanical config tweak (new code branch, several new env vars affecting memory fraction and expert placement), so despite the automated hunt finding nothing, a human with domain context should still confirm the new EP8 arm behaves as intended before it ships.

This review covers commit b0a5d2a, which is no longer the latest commit on this pull request; later commits are not covered by it.

@functionstackx

Copy link
Copy Markdown
Collaborator

InferenceX has switched away from unmaintainable bash scripts to YAML files that don't repeat the same stuff over and over again. Please merge the latest main into this PR: we have migrated single-node AgentX onto native srt-slurm (#3428), so AgentX configs are now declarative YAML recipes, not per-config 1000+ line bash slop scripts. Please also delete the old benchmarks/single_node/** scripts (see this recipe for the new format).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentx AgentX benchmarks, recipes, and infrastructure AMD full-sweep-enabled

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants